[LlamaTokenizerFast] Refactor default llama
#28881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
commented
Feb 20, 2024
This was referenced Mar 25, 2024
|
Coming next release! |
4 tasks
4 tasks
pcuenca
reviewed
Apr 23, 2024
ArthurZucker
commented
Apr 23, 2024
| @@ -1329,7 +1329,7 @@ def tokenizer(self, proto): | |||
| "You're trying to run a `Unigram` model but you're file was trained with a different algorithm" | |||
| ) | |||
| user_defined_symbols = [ | |||
| AddedToken(token, normalized=False, special=False) for token in proto.trainer_spec.user_defined_symbols | |||
| AddedToken(token, normalized=True, special=False) for token in proto.trainer_spec.user_defined_symbols | |||
There was a problem hiding this comment.
This is a must? Unless with only the split this works.
This was referenced May 6, 2024
Closed
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* push legacy to fast as well * super strange * Update src/transformers/convert_slow_tokenizer.py * make sure we are BC * fix Llama test * nit * revert * more test * style * update * small update w.r.t tokenizers * nit * don't split * lol * add a test for `add_prefix_space=False` * fix gemma tokenizer as well * update * fix gemma * nicer failures * fixup * update * fix the example for legacy = False * use `huggyllama/llama-7b` for the PR doctest * nit * use from_slow * fix llama
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This requires huggingface/tokenizers#1476 to be merged.
Finally FIXES ALL THE remaining tokenizer issues!
Fixes #29617 as well (will update Gemma one)
fixes #28577
fixes #29617
fixes #29626
fixes #29694
fixes #29868
fixes #29872
fixes #30416
enabled by huggingface/tokenizers#1476