Skip now failing test in the Trainer tests #28421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
changed the title
ArthurZucker
approved these changes
Jan 10, 2024
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
* Fix test * Skip
MadElf1337
pushed a commit
to MadElf1337/transformers
that referenced
this pull request
Jan 15, 2024
* Fix test * Skip
5 tasks
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
* Fix test * Skip
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
* Fix test * Skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
huggingface/accelerate#2319 introduced a revert on the DataLoader sampling logic to not use a SeedableRandomSampler by default as users were taken aback by the performance differences, so we've set it to
Falseby default. This test is now back to its old way, where it was failing for ages.As noted in the
skip, one of my next items to hit is a configuration for Accelerator that can be passed to theTrainingArgumentsthat can customize this, but for now it's not the case.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker