Change progress logging to once across all nodes #28373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddartha-RE
force-pushed
the
users/siddartha/pr/multinode
branch
from
e939d70 to
b824a63
Compare
siddartha-RE
changed the title
Done. Thank you for reviewing. |
siddartha-RE
force-pushed
the
users/siddartha/pr/multinode
branch
from
22e4c9a to
5b67725
Compare
ArthurZucker
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
LGTM, @muellerzr feel free to merge if this is alright for you as well
|
@muellerzr What do you think? Will close if you think this does not seem worth changing.. |
muellerzr
approved these changes
Jan 12, 2024
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
MadElf1337
pushed a commit
to MadElf1337/transformers
that referenced
this pull request
Jan 15, 2024
wgifford
pushed a commit
to wgifford/transformers
that referenced
this pull request
Jan 21, 2024
AjayP13
pushed a commit
to AjayP13/transformers
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change progress logging to be once across all nodes rather than once per node.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Library: