Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Trainer docs #28145

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[docs] Trainer docs #28145

merged 3 commits into from
Dec 20, 2023

Conversation

stevhliu
Copy link
Member

Part 2 of #27986 to finish cleaning up the Trainer API docs. This includes:

  • moving the CUDA extension installation problems to the performance and scalability debugging doc where it is more appropriate
  • GPU selection has its own section in the multiple GPU training doc
  • spin out the FSDP sections into their own docs
  • add a link from the Trainer guide to the FSDP guide

@stevhliu stevhliu requested a review from amyeroberts December 19, 2023 19:39
amyeroberts
amyeroberts approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looking good 😎!

Could you run pytest tests/utils/test_doc_samples.py to make sure everything passed before merging?

@stevhliu
Copy link
Member Author

Test is passing!

I rebased to incorporate the changes from #28135, but that didn't work for some reason, so I manually edited tests/utils/test_doc_samples.py to reflect the latest changes. Is this still ok since the change already exists on main?

@amyeroberts
Copy link
Collaborator

@stevhliu Yep - it should be fine!

@stevhliu stevhliu merged commit 01c081d into huggingface:main Dec 20, 2023
19 checks passed
@stevhliu stevhliu deleted the tidy-trainer-2 branch December 20, 2023 18:37
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
@stevhliu @staghado
[docs] Trainer docs (huggingface#28145)
1ef7d23 
* fsdp, debugging, gpu selection

* fix hfoption

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevhliu @amyeroberts