Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vip-llava docs #28085

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix Vip-llava docs #28085

merged 2 commits into from
Dec 15, 2023

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Dec 15, 2023

What does this PR do?

Fixes some nits on the Vip-Llava docs, in fact users should be aware that the correct prompt format is different from the llava one, as stated on the model card: https://huggingface.co/llava-hf/vip-llava-7b-hf#how-to-use-the-model

Also updated the docs in the modeling

cc @amyeroberts

@younesbelkada younesbelkada marked this pull request as ready for review December 15, 2023 19:05
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@younesbelkada younesbelkada merged commit 1faeff8 into main Dec 15, 2023
8 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch December 15, 2023 19:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
* Update vipllava.md

* Update modeling_vipllava.py
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
* Update vipllava.md

* Update modeling_vipllava.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants