Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong examples in llava usage. #28020

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix wrong examples in llava usage. #28020

merged 2 commits into from
Dec 15, 2023

Conversation

Lyken17
Copy link
Contributor

@Lyken17 Lyken17 commented Dec 13, 2023

What does this PR do?

This PR aims to fix the demo code of LlavaForConditionalGeneration

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

amyeroberts
amyeroberts reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Just a comment on using the processor instead of the tokenizer

src/transformers/models/llava/modeling_llava.py Outdated Show resolved Hide resolved
src/transformers/models/llava/modeling_llava.py Outdated Show resolved Hide resolved
@Lyken17
Copy link
Contributor Author

Lyken17 commented Dec 14, 2023

@amyeroberts I have revised the docs, please have a check.

amyeroberts
amyeroberts approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for fixing this and iterating!

@amyeroberts amyeroberts merged commit ffa04de into huggingface:main Dec 15, 2023
8 checks passed
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
@Lyken17 @iantbutler01
Fix wrong examples in llava usage. (huggingface#28020)
ea35e73 
* Fix wrong examples in llava usage.

* Update modeling_llava.py
@Lyken17 Lyken17 deleted the patch-1 branch December 18, 2023 00:27
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
@Lyken17 @staghado
Fix wrong examples in llava usage. (huggingface#28020)
202176e 
* Fix wrong examples in llava usage.

* Update modeling_llava.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lyken17 @amyeroberts