Fix 2 tests in FillMaskPipelineTests
#27889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Dec 7, 2023
Comment on lines
225
to
+230
| self.assertEqual( | ||
| nested_simplify(outputs, decimals=6), | ||
| [{"sequence": x["sequence"][:100]} for x in simplified], | ||
| [ | ||
| {"sequence": "My name is grouped", "score": 2.2e-05, "token": 38015, "token_str": " grouped"}, | ||
| {"sequence": "My name is accuser", "score": 2.1e-05, "token": 25506, "token_str": " accuser"}, | ||
| {"sequence": f"My name is,{dummy_str}"[:100]}, | ||
| {"sequence": f"My name is:,{dummy_str}"[:100]}, | ||
| ], |
There was a problem hiding this comment.
The input ids are truncated in this (part of) test. The output is also truncated. Let's just compare the first 100 characters.
ydshieh
commented
Dec 7, 2023
Comment on lines
+235
to
+236
| {"score": 0.2819, "token": 6, "token_str": ","}, | ||
| {"score": 0.0954, "token": 46686, "token_str": ":,"}, |
There was a problem hiding this comment.
just update some values (contributor might have different env.)
ArthurZucker
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test is introduced in #26234 which doesn't work as expected.
This PR update the values.