Fix device of masks in tests #27887
Merged
Fix device of masks in tests #27887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
requested review from
ArthurZucker and
LysandreJik
and removed request for
ArthurZucker
|
Strange that we don't see the issue on our CI. Do you know why @fxmarty? |
|
@ydshieh Can you try |
|
I am not sure it's weird. The transformers/.github/workflows/self-push.yml Line 133 in fc71e81 |
|
As discussed offline it did actually fail (https://github.com/huggingface/transformers/actions/runs/7124821720) so all good! |
5 tasks
nevikw39
pushed a commit
to NTHU-ML-2023-team19/transformers
that referenced
this pull request
Dec 7, 2023
fix device of mask in tests
nevikw39
pushed a commit
to NTHU-ML-2023-team19/transformers
that referenced
this pull request
Dec 7, 2023
fix device of mask in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, fix a bug introduced in #24587 in the GPU tests.