Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models from cpmant to derformable_detr #27884

Merged
merged 12 commits into from
Dec 13, 2023
Merged

Conversation

rajveer43
Copy link
Contributor

@rajveer43 rajveer43 commented Dec 7, 2023

What does this PR do?

Fixes #27885

#27885

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Documentation: @stevhliu and @MKhalusova

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for working on the next batch! The toctree also needs to be fixed; currently the Reinforcement learning models and Time series models sections are a bit mixed up.

docs/source/ja/model_doc/ctrl.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/cvt.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/cvt.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/data2vec.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/data2vec.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/deformable_detr.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/deformable_detr.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/deformable_detr.md Outdated Show resolved Hide resolved
docs/source/ja/model_doc/deformable_detr.md Outdated Show resolved Hide resolved
@rajveer43 rajveer43 changed the title Add model_docs from cpmant.md to deplot.md Add model_docs from cpmant.md to derformable_detr.md Dec 8, 2023
@rajveer43 rajveer43 requested a review from stevhliu December 8, 2023 02:09
@rajveer43
Copy link
Contributor Author

@stevhliu, I built docs locally, it should pass now.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just two more things!

docs/source/ja/model_doc/deformable_detr.md Outdated Show resolved Hide resolved
docs/source/ja/_toctree.yml Outdated Show resolved Hide resolved
@rajveer43 rajveer43 requested a review from stevhliu December 12, 2023 04:44
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

docs/source/ja/model_doc/decision_transformer.md Outdated Show resolved Hide resolved
@rajveer43
Copy link
Contributor Author

Did the final change as well, as we discussed on the mail, can you open a separate issue for a model doc files with listing of the model_docs files that are yet to be translated?

@rajveer43 rajveer43 requested a review from stevhliu December 13, 2023 14:21
@stevhliu stevhliu merged commit fe44b1f into huggingface:main Dec 13, 2023
8 checks passed
@rajveer43 rajveer43 changed the title Add model_docs from cpmant.md to derformable_detr.md Add models from cpmant to derformable_detr Dec 14, 2023
iantbutler01 pushed a commit to BismuthCloud/transformers that referenced this pull request Dec 16, 2023
* upfaste

* Update

* Update docs/source/ja/model_doc/deformable_detr.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/data2vec.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/cvt.md

Co-authored-by: Steven Liu <[email protected]>

* add suggestions

* Toctree update

* remove git references

* Update docs/source/ja/_toctree.yml

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/decision_transformer.md

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: Steven Liu <[email protected]>
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
* upfaste

* Update

* Update docs/source/ja/model_doc/deformable_detr.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/data2vec.md

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/cvt.md

Co-authored-by: Steven Liu <[email protected]>

* add suggestions

* Toctree update

* remove git references

* Update docs/source/ja/_toctree.yml

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/ja/model_doc/decision_transformer.md

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n-jp] Translating docs tojp
3 participants