in peft finetune, only the trainable parameters need to be saved #27825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@younesbelkada @pacman100 please help review the PR. |
younesbelkada
approved these changes
Dec 4, 2023
|
@sywangyi can you try to merge your branch with upstream main? Perhaps it will fix the current failing CI |
4 tasks
sywangyi
force-pushed
the
peft_deepspeed
branch
from
04c92a2 to
1c782b5
Compare
|
@younesbelkada I have rebased to main. the code quality check failure is not related with the PR |
3 tasks
|
@sywangyi can you try to re-run |
sywangyi
force-pushed
the
peft_deepspeed
branch
from
1c782b5 to
4a23a73
Compare
younesbelkada
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
In principle this looks good! Would like to hear @pacman100 's thoughts before a core maintainer approval
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@pacman100 could you help review the PR? Thanks. |
amyeroberts
reviewed
Dec 15, 2023
amyeroberts
approved these changes
Dec 15, 2023
sywangyi
force-pushed
the
peft_deepspeed
branch
from
4a23a73 to
bdfc628
Compare
to reduce the storage size and also save the time of checkpoint saving while using deepspeed for training Signed-off-by: Wang, Yi <[email protected]>
5 tasks
staghado
pushed a commit
to staghado/transformers
that referenced
this pull request
Jan 15, 2024
…gingface#27825) to reduce the storage size and also save the time of checkpoint saving while using deepspeed for training Signed-off-by: Wang, Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reduce the storage size and also save the time of checkpoint saving while using deepspeed for training
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.