Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for bitsandbytes import #27764

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Nov 29, 2023

What does this PR do ?

This PR adds more context to the ImportError that is raised when is_bitsandbytes_available() is False. In this PR, we introduced a GPU check. Hence, is_bitsandbytes_available() can be False even though bitsandbytes is installed.
Solves issue #26165
cc @NielsRogge as this happened to you too

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we can be a bit more specific on which part it is no? You are not using a GPU / torch.cuda not available as it's the only compatible GPU no?

@SunMarc SunMarc requested a review from ArthurZucker November 30, 2023 15:15
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SunMarc SunMarc merged commit abd4cbd into huggingface:main Dec 1, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants