Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time series] Add patchtst #27581

Merged
merged 311 commits into from
Nov 29, 2023
Merged

[Time series] Add patchtst #27581

merged 311 commits into from
Nov 29, 2023

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Nov 18, 2023

What does this PR do?

Adds the patchtst model

re-opened from closed #25927

namctin and others added 30 commits October 2, 2023 14:28
@namctin
add distribution head to forecasting
a0815ee
@kashif
formatting
d727ef7
@kashif
Merge branch 'main' into add-patchtst
de5a55b
@namctin
Add generate function for forecasting
e391bd3
@namctin
Add generate function to prediction task
a50f6c2
@kashif
formatting
8daf165
@kashif
use argsort
e2f8fd8
@kashif
add past_observed_mask ordering
1c8ec9d
@kashif
fix arguments
7ebaa61
@kashif
docs
f3dca25
@kashif
add back test_model_outputs_equivalence test
5349bf4
@kashif
formatting
eb7f547
@kashif
cleanup
a1cf42c
@kashif
formatting
6392f99
@kashif
use ACT2CLS
8a91544
@kashif
formatting
dfbea05
@kashif
fix add_start_docstrings decorator
1a0c55e
@namctin
add distribution head and generate function to regression task
0a4e58b 
add distribution head and generate function to regression task. Also made add PatchTSTForForecastingOutput,  PatchTSTForRegressionOutput.
@namctin
add distribution head and generate function to regression task
72a6e1e 
add distribution head and generate function to regression task. Also made add PatchTSTForForecastingOutput,  PatchTSTForRegressionOutput.
@kashif
fix typos
9908c6a
@kashif
add forecast_masking
91a4c46
@kashif
fixed tests
17c60a7
@kashif
Merge branch 'main' into add-patchtst
0eabe39
@kashif
use set_seed
a61ac77
@kashif
fix doc test
de7fb9e
@kashif
formatting
0fd0ce7
@kashif @NielsRogge
Update docs/source/en/model_doc/patchtst.md
cb52b6f 
Co-authored-by: NielsRogge <[email protected]>
@kashif
better var names
3daec96
@kashif
rename PatchTSTTranspose
c82022d
@kashif
fix argument names and docs string
687e3c8
@namctin
Copy link
Contributor

namctin commented Nov 27, 2023

@amyeroberts All the tests have passed. Can you take a look and merge if there is no other requests? Thank you!

amyeroberts
amyeroberts reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating - looking good!

Mostly nits. The main thing to address is adding the generation tests by adding the mixin to the model tester.

src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
tests/models/patchtst/test_modeling_patchtst.py Outdated Show resolved Hide resolved
tests/models/patchtst/test_modeling_patchtst.py Outdated Show resolved Hide resolved
tests/models/patchtst/test_modeling_patchtst.py Show resolved Hide resolved
src/transformers/models/patchtst/modeling_patchtst.py Outdated
[`~PreTrainedModel.from_pretrained`] method to load the model weights.
"""

PATCHTST_INPUTS_DOCSTRING = r"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't resolved

src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
src/transformers/models/patchtst/modeling_patchtst.py Outdated Show resolved Hide resolved
@namctin
Copy link
Contributor

namctin commented Nov 28, 2023

@amyeroberts We have either resolved or commented on all of your requests. Can you please review?

amyeroberts
amyeroberts approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work adding this model and iterating in the PR!

@namctin
Copy link
Contributor

namctin commented Nov 28, 2023

Thank you @amyeroberts for your careful review which makes the codes much cleaner.

@kashif kashif merged commit af8acc4 into huggingface:main Nov 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namctin namctin namctin left review comments

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashif @namctin @HuggingFaceDocBuilderDev @amyeroberts @wgifford