remove failing tests and clean FE files #27414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Nov 9, 2023
|
Could you run the feature extraction tests for all the audio models to double check they're passing before merging please! |
|
Sure thing! |
|
I've double check every audio models! Everything passes |
|
The documentation is not available anymore as the PR was closed or merged. |
|
Cool - do you have permissions to merge? I can merge if not |
|
I do, it's merged! |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* remove failing tests and clean FE files * remove same similar text from tvlt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes this, which was introduced by #26339.
To explain a bit, in #26339 I've mutualised an overriding of
to_dictwhich deletedmel_filtersandwindows. The failing test was testing to retrieve those parameters to assert equality.I've also cleaned a bit feature extractors that overrode
to_dict.