Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docstring] Fix docstring for ErnieConfig, ErnieMConfig #27029

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

Sparty
Copy link
Contributor

@Sparty Sparty commented Oct 23, 2023

What does this PR do?

Fixes #26638

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker ArthurZucker requested review from ydshieh and removed request for ydshieh October 24, 2023 09:34
@ArthurZucker
Copy link
Collaborator

Feel free to ping @ydshieh when this is ready for a review!

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 24, 2023

@Sparty Once ready for a review, could you remove the Draft mode. Thanks

@Sparty Sparty marked this pull request as ready for review October 24, 2023 15:26
@Sparty
Copy link
Contributor Author

Sparty commented Oct 24, 2023

I removed the draft mode. Thank you @ydshieh and @ArthurZucker

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny comment and we are ready go go!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@huggingface huggingface deleted a comment from github-actions bot Nov 23, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@ArthurZucker
Copy link
Collaborator

I'd want to merge, but we need this to be rebased @Sparty if you can run something like git pull upstream main and push 🤗

@Sparty Sparty force-pushed the Ernie2 branch 3 times, most recently from b4c4bc4 to 63f6bfd Compare January 9, 2024 23:11
@Sparty
Copy link
Contributor Author

Sparty commented Jan 10, 2024

I have rebased. @ydshieh @ArthurZucker Could you merge this?

@ydshieh ydshieh merged commit 6c78bbc into huggingface:main Jan 10, 2024
19 checks passed
@ydshieh
Copy link
Collaborator

ydshieh commented Jan 10, 2024

Thank you 🤗

staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
…27029)

* Remove ErnieConfig, ErnieMConfig check_docstrings

* Run fix_and_overwrite for ErnieConfig, ErnieMConfig

* Replace <fill_type> and <fill_docstring> in configuration_ernie, configuration_ernie_m.py with type and docstring values

---------

Co-authored-by: vignesh-raghunathan <[email protected]>
MadElf1337 pushed a commit to MadElf1337/transformers that referenced this pull request Jan 15, 2024
…27029)

* Remove ErnieConfig, ErnieMConfig check_docstrings

* Run fix_and_overwrite for ErnieConfig, ErnieMConfig

* Replace <fill_type> and <fill_docstring> in configuration_ernie, configuration_ernie_m.py with type and docstring values

---------

Co-authored-by: vignesh-raghunathan <[email protected]>
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
…27029)

* Remove ErnieConfig, ErnieMConfig check_docstrings

* Run fix_and_overwrite for ErnieConfig, ErnieMConfig

* Replace <fill_type> and <fill_docstring> in configuration_ernie, configuration_ernie_m.py with type and docstring values

---------

Co-authored-by: vignesh-raghunathan <[email protected]>
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
…27029)

* Remove ErnieConfig, ErnieMConfig check_docstrings

* Run fix_and_overwrite for ErnieConfig, ErnieMConfig

* Replace <fill_type> and <fill_docstring> in configuration_ernie, configuration_ernie_m.py with type and docstring values

---------

Co-authored-by: vignesh-raghunathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community Event] Docstring Sprint
4 participants