Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency PR to skip conversational tests to fix CI #26906

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Rocketknight1
Copy link
Member

The CI is currently red because of issues with the conversational pipeline tests on several models. This is caused by my recent PR #26795. I'm not sure why the issue didn't appear in that PR - maybe the tests weren't triggered for some reason.

This emergency temporary PR skips the tests for now while I work on a proper solution!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not only Marian failing at the moment?

@Rocketknight1
Copy link
Member Author

I'm seeing some issues with BlenderBot as well, so it's possible that not all tests are triggering in every CI run! I think to avoid blocking lots of other PRs, we should just disable the test until I can test everything and re-enable it.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks then!

@Rocketknight1 Rocketknight1 merged commit de55ead into main Oct 18, 2023
3 checks passed
@Rocketknight1 Rocketknight1 deleted the skip_conversational_tests branch October 18, 2023 14:33
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants