Fix Seq2seqTrainer decoder attention mask #26841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ArthurZucker
approved these changes
Oct 17, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Don't drop decoder_input_ids without also dropping decoder_attention_mask
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Seq2SeqTrainer drops
decoder_input_idsduring the generation step for metrics that expect text generation (likerouge) whenlabelsis present. However, it doesn't dropdecoder_attention_maskwhen it does this, which means that in some cases, we passdecoder_attention_maskwith nodecoder_input_ids, resulting in the model getting very confused and throwing a shape error.This PR fixes the issue.
Fixes #24567