use isinstance instead of type comparison #26748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
amyeroberts
reviewed
Oct 30, 2023
| @@ -20,7 +20,7 @@ | |||
| import os | |||
| import re | |||
| import sys | |||
| import time | |||
| from time import sleep | |||
There was a problem hiding this comment.
Personal opinion, but I think the previous version was better. Using time.sleep makes it more obvious which functionality and library is being used.
There was a problem hiding this comment.
right the issue was that there is a function time defined in the Message class which gives a "Redefinition" warning...
src/transformers/models/gptsan_japanese/tokenization_gptsan_japanese.py
Outdated
Show resolved
Hide resolved
…panese.py Co-authored-by: amyeroberts <[email protected]>
|
@amyeroberts thanks! so I relaxed the |
amyeroberts
approved these changes
Oct 30, 2023
|
fixed by #27144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for E721 errors which are annoying when doing
make stylewith a newerruff