Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #20715 #26734

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Revert #20715 #26734

merged 4 commits into from
Oct 11, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 11, 2023

What does this PR do?

Fix #25948

@ydshieh ydshieh requested a review from LysandreJik October 11, 2023 13:02
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 11, 2023

The documentation is not available anymore as the PR was closed or merged.

@LysandreJik
Copy link
Member

The import is missing from src/transformers/utils/__init__.py as well. Thanks for adding warnings!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Oct 11, 2023

put them back to __init__ too

@ydshieh
Copy link
Collaborator Author

ydshieh commented Oct 11, 2023

Merge as the failing test is irrelevant.

@ydshieh ydshieh merged commit e58cbed into main Oct 11, 2023
2 of 3 checks passed
@ydshieh ydshieh deleted the put_it_back branch October 11, 2023 14:46
helboukkouri pushed a commit to helboukkouri/transformers that referenced this pull request Oct 16, 2023
* fix

---------

Co-authored-by: ydshieh <[email protected]>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* fix

---------

Co-authored-by: ydshieh <[email protected]>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* fix

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change on torch_required.
3 participants