Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Grounding DINO #25451

Closed
wants to merge 7 commits into from

Conversation

EduardoPach
Copy link
Contributor

@EduardoPach EduardoPach commented Aug 10, 2023

What does this PR do?

This PR adds Grounding DINO

Fixes #25423

To-Do's:

  • Port vision backbone
  • Port Text backbone
  • Port Feature Enhancer
  • Port Cross-Modality Decoder

@EduardoPach EduardoPach mentioned this pull request Aug 10, 2023
2 tasks
@sgugger
Copy link
Collaborator

sgugger commented Aug 11, 2023

cc @amyeroberts for information. Please let us know when your PR is ready for review!

@EduardoPach
Copy link
Contributor Author

EduardoPach commented Aug 31, 2023

@amyeroberts Hey, I've actually started a new branch to port the model because in the branch from this PR, I've done add-new-model-like and then swin, but talking to @NielsRogge he mentioned that starting from deformable-detr would be easier (which was a SUPER helpful tip btw). Should I close this PR and open a new one with the correct branch? (still WIP, but almost there)

@amyeroberts
Copy link
Collaborator

@EduardoPach Do whatever is easiest for you in terms of code management. If you open a new PR, just make sure to link to it in a comment on this one so it can be easily tracked.

@EduardoPach
Copy link
Contributor Author

@amyeroberts opened a new PR in #26087 as mentioned. Should I close this one?

@amyeroberts
Copy link
Collaborator

@EduardoPach I can close it for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Grounding DINO
3 participants