Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up image processors - cast to array before BatchFeature #31205

Open
amyeroberts opened this issue Jun 3, 2024 · 5 comments · May be fixed by #34432
Open

Speed up image processors - cast to array before BatchFeature #31205

amyeroberts opened this issue Jun 3, 2024 · 5 comments · May be fixed by #34432
Labels
Feature request Request for a new feature Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want!

Comments

@amyeroberts
Copy link
Collaborator

Feature request

Complete work initially started in #28221

Motivation

Converting the model outputs to an array before creating the BatchFeature object can speed up image processing, especially for nested outputs, such as for videos.

Your contribution

Open to the community to add

@amyeroberts amyeroberts added Feature request Request for a new feature Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want! labels Jun 3, 2024
@g1y5x3 g1y5x3 mentioned this issue Jun 4, 2024
5 tasks
@yaswanth19
Copy link

Hi @amyeroberts , If this Issue is still open then I would like to work on it. If so, can you provide me some more context to work on.

@amyeroberts
Copy link
Collaborator Author

Hi @yaswanth19, apologies for the delay in response.

The idea is similar to what's done here in idefics 3, where the inputs are converted to numpy arrays before passing to BatchFeature.

I'm going to be off for a while, so if you're still keen to take this on, @yonigozlan is the best person to ping for first review 🤗

@csking101
Copy link

Hi @amyeroberts @yonigozlan , is this issue still open? If so, could I work on it?

@yaswanth19
Copy link

@csking101 I am working on it and will raise the PR soon

@csking101
Copy link

@csking101 I am working on it and will raise the PR soon

Sure, thanks for informing me!

@yaswanth19 yaswanth19 linked a pull request Oct 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants