use channel name directly instead of ID

huggingface · Apr 5, 2024 · bae019e · bae019e
1 parent a20fd8b
commit bae019e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/self-scheduled-caller.yml b/.github/workflows/self-scheduled-caller.yml
@@ -16,7 +16,7 @@ jobs:
     with:
       job: run_tests_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
 
   torch-pipeline:
@@ -25,7 +25,7 @@ jobs:
     with:
       job: run_pipelines_torch_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
 
   tf-pipeline:
@@ -34,7 +34,7 @@ jobs:
     with:
       job: run_pipelines_tf_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
 
   example-ci:
@@ -43,7 +43,7 @@ jobs:
     with:
       job: run_examples_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
 
   deepspeed-ci:
@@ -52,7 +52,7 @@ jobs:
     with:
       job: run_all_tests_torch_cuda_extensions_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
 
   quantization-ci:
@@ -61,5 +61,5 @@ jobs:
     with:
       job: run_tests_quantization_torch_gpu
       # See the comment for `ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID` in `.github/workflows/slack-report.yml`.
-      env_name_for_slack_report_channel: CI_SLACK_CHANNEL_DUMMY_TESTS
+      env_name_for_slack_report_channel: "#transformers-ci-feedback-tests"
     secrets: inherit
diff --git a/utils/notification_service.py b/utils/notification_service.py
@@ -860,7 +860,8 @@ def prepare_reports(title, header, reports, to_truncate=True):
     # `CI_SLACK_CHANNEL_ID`, `CI_SLACK_CHANNEL_ID_DAILY`, `CI_SLACK_CHANNEL_DUMMY_TESTS`, etc.
     ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID = os.environ["ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID"]
     # The value of `CI_SLACK_REPORT_CHANNEL_ID` is the Slack channel ID where we want to send the CI report.
-    CI_SLACK_REPORT_CHANNEL_ID = os.environ[ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID]
+    # CI_SLACK_REPORT_CHANNEL_ID = os.environ[ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID]
+    CI_SLACK_REPORT_CHANNEL_ID = ENV_NAME_FOR_CI_SLACK_REPORT_CHANNEL_ID
 
     # runner_status = os.environ.get("RUNNER_STATUS")
     # runner_env_status = os.environ.get("RUNNER_ENV_STATUS")