Updated incorrect test case.

huggingface · Dec 22, 2024 · 8accf30 · 8accf30
1 parent 84e91d1
commit 8accf30
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/tests/trainer/test_trainer.py b/tests/trainer/test_trainer.py
@@ -4236,15 +4236,15 @@ def test_save_best_checkpoint(self):
 
         # Case 4: Metric name not provided and save_best_strategy is "steps" (i.e., not "best").
         with tempfile.TemporaryDirectory() as tmpdir:
-            with self.assertRaises(ValueError) as context:
-                trainer = get_regression_trainer(
-                    a=1.5,
-                    b=2.5,
-                    output_dir=tmpdir,
-                    learning_rate=0.1,
-                    eval_strategy="epoch",
-                    save_strategy="steps",
-                )
+            trainer = get_regression_trainer(
+                a=1.5,
+                b=2.5,
+                output_dir=tmpdir,
+                learning_rate=0.1,
+                eval_strategy="epoch",
+                save_strategy="steps",
+                load_best_model_at_end=True,
+            )
             self.assertTrue(trainer.args.metric_for_best_model == "loss")