Skip to content

Commit

Permalink
Fix check_training_gradient_checkpointing (#34806)
Browse files Browse the repository at this point in the history
fix

Co-authored-by: ydshieh <[email protected]>
  • Loading branch information
ydshieh and ydshieh authored Nov 19, 2024
1 parent 05ebe8b commit 469eddb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/test_modeling_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,9 @@ def check_training_gradient_checkpointing(self, gradient_checkpointing_kwargs=No
]
or not model_class.supports_gradient_checkpointing
):
self.skipTest(reason=f"`supports_gradient_checkpointing` is False for {model_class.__name__}.")
# TODO (ydshieh): use `skipTest` once pytest-dev/pytest-subtests/pull/169 is merged
# self.skipTest(reason=f"`supports_gradient_checkpointing` is False for {model_class.__name__}.")
continue

config, inputs_dict = self.model_tester.prepare_config_and_inputs_for_common()
config.use_cache = False
Expand Down

0 comments on commit 469eddb

Please sign in to comment.