Skip to content

Commit

Permalink
check why we need this part
Browse files Browse the repository at this point in the history
  • Loading branch information
ydshieh committed Oct 3, 2024
1 parent fd97a52 commit 2352f7a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/self-comment-slow-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
types: [created, deleted]
pull_request:
concurrency:
# But this will cancel the current job no ? Because they have the same PR number ...
# But this will cancel the current job no ? Because they have the same PR number ... (any comment even not the target one)
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number }}
cancel-in-progress: ${{ github.event.issue.pull_request != null || github.event.pull_request != null }}

Expand All @@ -32,6 +32,7 @@ jobs:
echo "${{ github.event.pull_request }}"
echo "${{ github.event.issue.pull_request != null }}"
echo "${{ github.event.pull_request != null }}"
ecjp "${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number }}"
# - name: Set up GitHub CLI
# uses: actions/checkout@v4
Expand Down

0 comments on commit 2352f7a

Please sign in to comment.