Fin!

huggingface · Apr 12, 2024 · 16c3bf7 · 16c3bf7
1 parent 5d9a39a
commit 16c3bf7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/transformers/training_args.py b/src/transformers/training_args.py
@@ -175,7 +175,8 @@ class OptimizerNames(ExplicitEnum):
 
 # Sometimes users will pass in a `str` repr of a dict in the CLI
 # We need to track what fields those can be. Each time a new arg
-# has a dict type, it must be added to this list
+# has a dict type, it must be added to this list.
+# Important: These should be typed with Optional[Union[dict,str,...]]
 VALID_DICT_FIELDS = [
     "accelerator_config",
     "fsdp_config",
@@ -1148,7 +1149,7 @@ class TrainingArguments:
             )
         },
     )
-    accelerator_config: Optional[Union[AcceleratorConfig, dict, str]] = field(
+    accelerator_config: Optional[Union[dict, str, AcceleratorConfig]] = field(
         default=None,
         metadata={
             "help": (