Add TODO to clean this up a bit

huggingface · Dec 7, 2023 · 0c5c883 · 0c5c883
1 parent c217246
commit 0c5c883
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/transformers/modeling_tf_utils.py b/src/transformers/modeling_tf_utils.py
@@ -2893,6 +2893,9 @@ def from_pretrained(
         model = cls(config, *model_args, **model_kwargs)
 
         if tf_to_pt_weight_rename is None and hasattr(model, "tf_to_pt_weight_rename"):
+            # TODO Matt: This is a temporary workaround to allow weight renaming, but requires a method
+            #            to be defined for each class that requires a rename. We can probably just have a class-level
+            #            dict and a single top-level method or something and cut down a lot of boilerplate code
             tf_to_pt_weight_rename = model.tf_to_pt_weight_rename
 
         if from_pt: