Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #803 #804

Merged
merged 6 commits into from
Dec 7, 2024
Merged

Fixes Issue #803 #804

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58b8346
support user defined tokens by bounding timestamp token if statement
aravindMahadevan Jun 11, 2024
7d0cdbf
Update src/tokenizers.js
aravindMahadevan Jun 11, 2024
e6e7e93
calculate timestamp_end instead of hardcoding
aravindMahadevan Jun 14, 2024
03b2c40
Update tokenizers.js
aravindMahadevan Jun 14, 2024
5a61999
Merge conflict resolution
xenova Dec 7, 2024
2ad01ad
Merge branch 'main' into main
xenova Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tokenizers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3610,6 +3610,11 @@ export class WhisperTokenizer extends PreTrainedTokenizer {
let chunk = new_chunk();
let time_offset = 0.0;
const timestamp_begin = this.model.convert_tokens_to_ids(["<|notimestamps|>"])[0] + 1;
// Whisper timestamp tokens start from 0.00 and go to timestamp 30.00 in 0.02 increments.
// We can calculate the last time stamp token as timestamp_begin plus the number of tokens
// tokens from 0.00 to 30.00 which is 1500.
const total_timestamp_tokens = (30.00 - 0.00) / 0.02;
const timestamp_end = timestamp_begin + total_timestamp_tokens;
xenova marked this conversation as resolved.
Show resolved Hide resolved

let previous_tokens = [];
let previous_token_timestamps = [];
Expand Down Expand Up @@ -3697,7 +3702,7 @@ export class WhisperTokenizer extends PreTrainedTokenizer {
} else {
// 2/ This is a regular special token, ignoring it
}
} else if (token >= timestamp_begin) {
} else if (token >= timestamp_begin && token <= timestamp_end) {
// 3/ Timestamp token
const time = (token - timestamp_begin) * time_precision + time_offset;
const rounded_time = round(time, 2);
Expand Down