-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing of pipeline
helper function
#485
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
After a bit of tinkering, I think I've got a good solution, which I've tested with the image segmentation pipeline, since this was requested by @wesbos in the original issue. This also means when you hover over the class name, you'll get example code to help you out. |
Wow, very nice work! 💯 👍 |
This changed the interface of |
Hi there. This was fixed in a subsequent version (2.13.3), could you please upgrade and try again? |
I updated to 2.13.4 when I noticed the breakage and just narrowed it down to 2.13.1 release. Even with 2.13.4 I had to rewrite my TS code to work with these changes. They are good changes but they are breaking changes so should have caused a version bump rather than a patch level. Specifically I had to change the type of the function returned by |
A first attempt at improving the types inferred when creating a new pipeline.
Still to do: return actual call parameters instead of
(...args: any[]) => any
.Closes #484.