Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'ready' status in the ProgressInfo type #1070

Merged

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Dec 4, 2024

Closes #1064

@ocavue ocavue marked this pull request as ready for review December 4, 2024 02:42
@pelikhan
Copy link

pelikhan commented Dec 4, 2024

ProgressInfo needs to be ammended too.

* @property {'initiate' | 'download' | 'progress' | 'done'} status The status of the progress item.

@ocavue
Copy link
Contributor Author

ocavue commented Dec 5, 2024

Sorry I'm not following you. What I amended in this PR is exact the ProgressInfo type in src/utils/core.js.

@pelikhan
Copy link

pelikhan commented Dec 5, 2024

My bad! I taught this PR was already merged. Thanks for fixing the issue!

Copy link
Collaborator

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@xenova xenova merged commit 7dffb9a into huggingface:main Dec 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ready event not exposed on ProgressInfo type
4 participants