[BUG] When padding an image, the dimensions get stretched #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that padding was stretching the original image, and the right side was overflowing the container.
Example
This is the code I used to generate the images.
I resize the images, so that they can be padded again to the same height as the original image.
As you can see above, the old solution will add the 128 pixel padding to the top and left, however the image is resized and drawn with the same size as the canvas, hence it is cropped by 128 pixels on the right and bottom.
However, the new solution will correctly draw the image with the provided padding all around as we now draw the image with the same dimensions that it was passed in with.
Explanation
The current implementation was drawing the image with a width of
newWidth
, wherenewWidth
will be the entire width.This is incorrect, since the width should remain unchanged when drawing, otherwise the image will become stretched.
As a result, we are getting the correct left padding and top padding, but the right and bottom of the image are getting cropped off since the image is being stretched out.
From the docs, the
sWidth
andsHeight
should matchdWidth
anddHeight
.