Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python bindings README.md #543

Closed
wants to merge 1 commit into from

Conversation

JavClaude
Copy link

tokenizer.train(["./path/to/dataset/1.txt"], trainer=trainer)

Fix the "PyTokenizer.train() got multiple values for argument: trainer" error when the "files" parameter is missing

@n1t0
Copy link
Member

n1t0 commented Nov 25, 2020

I'm not sure to understand. The files parameter is not optional so it can't not be there.

@JavClaude
Copy link
Author

JavClaude commented Nov 25, 2020

The parameter is not mentioned in the documentation. What induces the error when trying the piece of code.
This does not fix the error in itself, just the document induces an error. Sorry for the incomprehension

@marcglobality
Copy link

I just came here because was having the mentioned error when running the example in the docs. Any reason not to merge this @n1t0 ?

@marcglobality
Copy link

I think the error appeared since #544

@n1t0
Copy link
Member

n1t0 commented Dec 14, 2020

The README reflects the most up to date state of the library, not the latest stable. If you try the 0.10.0rc1, I'm pretty sure this error does not exist.
Maybe we should make this clearer in the readme though.

@marcglobality
Copy link

The README reflects the most up to date state of the library, not the latest stable. If you try the 0.10.0rc1, I'm pretty sure this error does not exist.
Maybe we should make this clearer in the readme though.

For the future, I think the README should be updated to the latest stable, not the latest rc. Given that eventually the RC will becomes stable and the example in the README will work, I think @JavClaude can close this PR then?

If you feel motivated, it'd be great to get in the README the example here 723ee7c#diff-810f2de0965b0a169a00cee33465f4165347b006b5360ae3b1001723a6e9ebd3R19 to train with in-memory data

@JavClaude JavClaude closed this Dec 14, 2020
@JavClaude JavClaude deleted the patch-1 branch December 14, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants