Testing ABI3 wheels to reduce number of wheels #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
reviewed
Nov 7, 2024
| @@ -16,7 +16,7 @@ jobs: | |||
| runs-on: windows-latest | |||
| strategy: | |||
| matrix: | |||
| python: ["3.7", "3.8", "3.9", "3.10"] | |||
| python: ["3.9", "3.10", "3.11", "3.12", "3.13"] | |||
| let obj = PyObject::from_owned_ptr(py, unicode); | ||
| let s = obj.downcast_bound::<PyString>(py)?; | ||
| Ok(s.to_string_lossy().trim_matches(char::from(0)).to_owned()) | ||
| Ok(std::str::from_utf8(bytes)?.to_owned()) |
There was a problem hiding this comment.
I haven't checked that properly.
flake.lock
Outdated
There was a problem hiding this comment.
I understand if you wish to remove. Having those is extremely practical when using devenvs/nix.
I'm currently keeping copies on every machine, and rewriting them all the time is just a tad annoying.
I'll remove for now, and convert you later :)
ArthurZucker
approved these changes
Nov 14, 2024
Comment on lines
-167
to
-168
| - name: Upload to PyPi | ||
| working-directory: ./bindings/python |
There was a problem hiding this comment.
do you want to do a RC for this?
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.