Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strip python type #1602

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Fix strip python type #1602

merged 6 commits into from
Aug 7, 2024

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Aug 7, 2024

Fixes the type of PyStrip which was never correctly computed 🤯

@ArthurZucker ArthurZucker marked this pull request as ready for review August 7, 2024 13:24
@ArthurZucker ArthurZucker requested a review from Narsil August 7, 2024 13:24
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit 49dafd7 into main Aug 7, 2024
12 checks passed
@ArthurZucker ArthurZucker deleted the fix-strip branch August 7, 2024 13:36
ArthurZucker added a commit that referenced this pull request Aug 8, 2024
* update

* the fix

* Revert "update"

This reverts commit 4c2f32f.

* add a test and rebase

* style

* oups

sounds fun

what I hope for

nit

Is this what's expected?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants