Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display capabilities to tokenizers objects #1542
Add display capabilities to tokenizers objects #1542
Changes from 53 commits
61804d9
a56da5f
f1a6a97
4a49530
f4af616
88630dc
b9d44da
a90ec22
2224275
4d9204e
4c2aca1
904ce70
6413810
fda66f5
20c9fc4
86c77b6
a429642
3cec010
8d77286
e48cd3a
27576e5
0d9a452
35373de
1c6d272
df51116
4b4b833
59a89c9
ac9b849
a3f7439
cf5b6f3
5d33243
b73c43d
3e16df7
b214d77
0654831
a15e3cc
6023192
ebf1258
477a9b5
93a1e63
7591f2b
f50e4e0
4f15052
85c7b69
0a16ca0
35d442d
a3cc764
5b20fa7
15f877e
9c45e8f
4a34870
e0d35e0
fe95add
2770099
3d0eb0a
11a3601
f6fa136
2a54482
998b2a3
4df6cc2
a9c6c61
aefdc91
f67af9c
4c3f37a
292475f
99cb054
5c930e9
f87bb97
c4b4f3c
e712079
5540136
ba03c16
d0e741b
19afb66
9559dea
e53f4ca
18238dd
269ff21
e799602
93ad593
3aa0138
011340b
3fc31d0
51d3f61
acb8196
951b6e6
c2a320c
2048c02
104fe0c
7db6109
c7cd927
e4cf65a
39ffc28
0a3bb18
c436b23
e5b059f
ff825a7
c30df0c
b78e11c
a99c645
9022470
64b8df0
27cad45
ceabef3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this native rust or are these capabilities from the
derive_more
crate?(the
display
macro)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, are you sure
.unwrap
is the right thing? Perhaps an.unwrap_or_else(some_default_display_fn)
would work best?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
read()
returns aResult
, then you can probably convert it to aPyResult
here rather than unwrapping it.If it returns an
Option
, then perhaps returning a default value rather thanunwrapping
would be preferable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I'd have the patience to comment all of them, it appears not to be the case, I trust you got the point by now