-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove CLI - this was originally intended for local development #1442
Conversation
Hi, thanks for this very nice PR and detailed work. Do you have any reason why deactivating You are correct that the CLI is not highly maintained and not really a core dependency, although such a change would be breaking a require For the name, my instinct would be @ArthurZucker what's your opinion ? |
Even better!
No, nothing in particular - it was more of a bit of confusion when I was looking at the source and saw cli tucked in there behind a feature flag |
Down to remove it as well 😉 |
2b0da4f
to
fcb12c0
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Done! |
fcb12c0
to
cc435f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for cleaning
Removing the CLI that was originally intended for local development
The CLI functionality has been split out into its own crate. This means the maintokenizers
project doesn't have to contend with compiling the clap library nor messing with enabling/disabling the CLI feature flag. This also allows the CLI to be published to be made available for use through crates, Homebrew, etc. if that is of interest.With splitting out the CLI, workspaces are added - this also gives the benefit of being able to run the CLI from anywhere within the project but not bring in the clap dependency intotokenizers
. A lot of the crate boilerplate attributes are standardized in the rootCargo.toml
and inherited by the individual crates. Currently both crates share the same version but this can easily be changed if thats desired.I don't think this is a breaking change since my understanding is that the CLI is more of an internal developer feature, but please correct me if I am wrong on that assumption