Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to skip special tokens #1419

Closed
wants to merge 16 commits into from

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Dec 18, 2023

Allow skipping special tokens when encoding

fixes #1347, fixes #1391 fixes #1368

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker
Copy link
Collaborator Author

ArthurZucker commented Dec 18, 2023

This works as expected for now:

>>> from transformers import AutoTokenizer
>>> tokenizer = AutoTokenizer.from_pretrained("gp2") 
>>> tokenizer.tokenize("<|endoftext|>")
['<|endoftext|>']

>>> tokenizer._tokenizer.encode_special_tokens = True
>>> tokenizer.tokenize("<|endoftext|>")
['<', '|', 'end', 'of', 'text', '|', '>']

the goal is to support passing this as a kwargs, similarly to the slow!
This way you can both save it and activate it in a __call__.

@ArthurZucker
Copy link
Collaborator Author

ArthurZucker commented Dec 18, 2023

TODO :

  • Evaluate on a benchmark if this does not slow down too much : good to go
  • Add tests
  • open a PR in transformers for a followup

@ArthurZucker
Copy link
Collaborator Author

Before merging I just want to add a getter, and make sure we can just set it with tokenizer.encode_special_tokens = True.

@ArthurZucker
Copy link
Collaborator Author

PR is not on the correct branch lol

@ArthurZucker ArthurZucker deleted the encode-special-tokens branch January 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants