Skip to content

Commit

Permalink
Arg name correction: auth_token -> token (#1621)
Browse files Browse the repository at this point in the history
* Arg name correction: auth_token -> token

* Arg name correction in .rs: auth_token -> token

* update from_pretrained.rs file as well

---------

Co-authored-by: Rene Ravenel <[email protected]>
Co-authored-by: Arthur Zucker <[email protected]>
  • Loading branch information
3 people authored Oct 24, 2024
1 parent 9b77c05 commit a8738a9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions bindings/python/py_src/tokenizers/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@ class Tokenizer:
pass

@staticmethod
def from_pretrained(identifier, revision="main", auth_token=None):
def from_pretrained(identifier, revision="main", token=None):
"""
Instantiate a new :class:`~tokenizers.Tokenizer` from an existing file on the
Hugging Face Hub.
Expand All @@ -982,7 +982,7 @@ class Tokenizer:
a tokenizer.json file
revision (:obj:`str`, defaults to `main`):
A branch or commit id
auth_token (:obj:`str`, `optional`, defaults to `None`):
token (:obj:`str`, `optional`, defaults to `None`):
An optional auth token used to access private repositories on the
Hugging Face Hub
Expand Down
12 changes: 6 additions & 6 deletions bindings/python/src/tokenizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -578,19 +578,19 @@ impl PyTokenizer {
/// a tokenizer.json file
/// revision (:obj:`str`, defaults to `main`):
/// A branch or commit id
/// auth_token (:obj:`str`, `optional`, defaults to `None`):
/// token (:obj:`str`, `optional`, defaults to `None`):
/// An optional auth token used to access private repositories on the
/// Hugging Face Hub
///
/// Returns:
/// :class:`~tokenizers.Tokenizer`: The new tokenizer
#[staticmethod]
#[pyo3(signature = (identifier, revision = String::from("main"), auth_token = None))]
#[pyo3(text_signature = "(identifier, revision=\"main\", auth_token=None)")]
#[pyo3(signature = (identifier, revision = String::from("main"), token = None))]
#[pyo3(text_signature = "(identifier, revision=\"main\", token=None)")]
fn from_pretrained(
identifier: &str,
revision: String,
auth_token: Option<String>,
token: Option<String>,
) -> PyResult<Self> {
let path = Python::with_gil(|py| -> PyResult<String> {
let huggingface_hub = PyModule::import_bound(py, intern!(py, "huggingface_hub"))?;
Expand All @@ -601,8 +601,8 @@ impl PyTokenizer {
(intern!(py, "revision"), &revision),
]
.into_py_dict_bound(py);
if let Some(auth_token) = auth_token {
kwargs.set_item(intern!(py, "token"), auth_token)?;
if let Some(token) = token {
kwargs.set_item(intern!(py, "token"), token)?;
}
let path: String = hf_hub_download.call((), Some(&kwargs))?.extract()?;
Ok(path)
Expand Down
6 changes: 3 additions & 3 deletions tokenizers/src/utils/from_pretrained.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ use std::path::PathBuf;
pub struct FromPretrainedParameters {
pub revision: String,
pub user_agent: HashMap<String, String>,
pub auth_token: Option<String>,
pub token: Option<String>,
}

impl Default for FromPretrainedParameters {
fn default() -> Self {
Self {
revision: "main".into(),
user_agent: HashMap::new(),
auth_token: None,
token: None,
}
}
}
Expand Down Expand Up @@ -60,7 +60,7 @@ pub fn from_pretrained<S: AsRef<str>>(
}

let mut builder = ApiBuilder::new();
if let Some(token) = params.auth_token {
if let Some(token) = params.token {
builder = builder.with_token(Some(token));
}
let api = builder.build()?;
Expand Down

0 comments on commit a8738a9

Please sign in to comment.