Attempt for cleverer auto batch_prefill values (some simplifications). #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
reviewed
Dec 9, 2024
| // TODO This calculation depends on the actual implementation | ||
| let dtype_size = 2; | ||
| let mlp_size = self.intermediate_size?; | ||
| Some((mlp_size + mlp_size / 2) * self.num_experts * dtype_size * 3) |
There was a problem hiding this comment.
Maybe a comment where mlp_size / 2 comes from?
| enum Gpu { | ||
| RTX4090, | ||
| T4, | ||
| L4, |
There was a problem hiding this comment.
We probably want L40 as well, since we are using them now?
| # switch on equivalent logits based on the position in the batch. | ||
| # 1 output being different is not uncommon | ||
| if sum(equals) < len(equals) - 1: | ||
| assert outputs == expected |
There was a problem hiding this comment.
I'm missing something. Can't this only be true when sum(equals) == len(equals)?
There was a problem hiding this comment.
I want the error message to be about the content and containing the diff.
Co-authored-by: Daniël de Kok <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.