Add llama.cpp backend #2723
Open
Add llama.cpp backend #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock
Hugoch
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Thanks @mfuntowicz ! I can't get a correct generation using the Docker so I think something is wrong with tokenizer. I'll dig deeper later today!
Co-authored-by: Hugo Larcher <[email protected]>
Co-authored-by: Hugo Larcher <[email protected]>
… the size of the generated core allocation
* feat: Fix Cmakelist to allow building on Darwin platform * fix: Fix tokenizer in llama.cpp Dockerfile
co42
reviewed
Dec 9, 2024
| None => break, | ||
| Some((ctx, sender)) => { | ||
| if let Err(e) = backlog.send((ctx, sender)).await { | ||
| todo!("What do we do") |
There was a problem hiding this comment.
Looks like it can only happen id the channel is closed (all receivers are drop), so I guess you can break the loop and just return / exit
Co-authored-by: Corentin REGAL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation of llama.cpp as potential backend for TGI.
It mostly targets CPU inference in a single/multi stream scheduling fashion, potentially spawning multiple instances of the same model over a non-overlapping subset of the CPU cores.
The current implementation only allows a single request to be running on a working, this constraint will be removed later on.
The current implementation also dupplicate the weights for each worker, this constraint can potentially be removed later on.