Stream options. #2533
Merged
Stream options. #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick turnaround on this! This PR closes #2531 |
danieldk
previously approved these changes
Sep 18, 2024
nix/client.nix
Outdated
Comment on lines
17
to
19
| nativeBuildInputs = [ ]; | ||
|
|
||
| pythonRemoveDeps = [ ]; |
router/src/server.rs
Outdated
| @@ -590,7 +590,7 @@ async fn generate_stream_internal( | |||
| let event = on_message_callback(stream_token); | |||
| yield Ok(event); | |||
| } | |||
| // Yield event for last token and compute timings | |||
| // Yield event for lat token and compute timings | |||
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
* Stream options. * Fetch stuff from nix integration test for easier testing. * Adding the assert. * Only send the usage when asked for. * Update the docs. * Impure test because we need network. * develop. * Optional usage. * Fixes. * Workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.