-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no repeat ngram size ci #2308
Closed
Closed
no repeat ngram size ci #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ErikKaum
force-pushed
the
feature/no_repeat_ngram_size_ci
branch
from
July 26, 2024 09:27
f98d8ae
to
496d851
Compare
drbh
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding @ErikKaum looks good but may need a couple changes.
Additionally it would be nice to add a new integration-test
that uses the new generation parameter.
ErikKaum
force-pushed
the
feature/no_repeat_ngram_size_ci
branch
3 times, most recently
from
July 31, 2024 15:54
303be7d
to
ffdefa1
Compare
ErikKaum
force-pushed
the
feature/no_repeat_ngram_size_ci
branch
from
August 1, 2024 10:10
e3a1cff
to
98e790e
Compare
drbh
requested changes
Aug 1, 2024
Closed, more details in: #2219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?