Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no repeat ngram size ci #2308

Closed
wants to merge 16 commits into from
Closed

Conversation

ErikKaum
Copy link
Member

What does this PR do?

@ErikKaum ErikKaum force-pushed the feature/no_repeat_ngram_size_ci branch from f98d8ae to 496d851 Compare July 26, 2024 09:27
@ErikKaum ErikKaum requested a review from drbh July 26, 2024 09:40
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding @ErikKaum looks good but may need a couple changes.

Additionally it would be nice to add a new integration-test that uses the new generation parameter.

server/text_generation_server/utils/logits_process.py Outdated Show resolved Hide resolved
benchmark/src/main.rs Show resolved Hide resolved
@ErikKaum ErikKaum requested a review from drbh July 29, 2024 09:48
@ErikKaum ErikKaum force-pushed the feature/no_repeat_ngram_size_ci branch 3 times, most recently from 303be7d to ffdefa1 Compare July 31, 2024 15:54
@ErikKaum ErikKaum force-pushed the feature/no_repeat_ngram_size_ci branch from e3a1cff to 98e790e Compare August 1, 2024 10:10
@ErikKaum
Copy link
Member Author

Closed, more details in: #2219

@ErikKaum ErikKaum closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants