Consistently take prefix in model constructors
#2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
previously approved these changes
Jul 5, 2024
danieldk
force-pushed
the
maintenance/accept-prefix
branch
from
e7d3bfe to
9d5ca8e
Compare
danieldk
force-pushed
the
maintenance/accept-prefix
branch
from
4889ae0 to
917e9de
Compare
ErikKaum
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Consistently take `prefix` in model constructors * Release test check fix * Misc refactor-related fixes
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
* Consistently take `prefix` in model constructors * Release test check fix * Misc refactor-related fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consistently take
prefixin model constructors. Should fix models that don't work anymore after the PR.Draft to run release tests in CI.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.