Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest release marker #2114

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add pytest release marker #2114

merged 2 commits into from
Jun 25, 2024

Conversation

danieldk
Copy link
Member

What does this PR do?

Annotate a test with @pytest.mark.release and it only gets run with pytest integration-tests --release.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Annotate a test with `@pytest.mark.release` and it only gets run
with `pytest integration-tests --release`.
@Narsil
Copy link
Collaborator

Narsil commented Jun 25, 2024

Can you add the flag --release ( it's when we run the CI on main, like where we push on dockerhub + azure &co)

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldk danieldk merged commit fc9c315 into main Jun 25, 2024
8 checks passed
@danieldk danieldk deleted the ci/release-tests branch June 25, 2024 14:53
glegendre01 pushed a commit that referenced this pull request Jul 2, 2024
* Add pytest release marker

Annotate a test with `@pytest.mark.release` and it only gets run
with `pytest integration-tests --release`.

* Mark many models as `release` to speed up CI
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* Add pytest release marker

Annotate a test with `@pytest.mark.release` and it only gets run
with `pytest integration-tests --release`.

* Mark many models as `release` to speed up CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants