feat: sort cuda graphs in descending order #2104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorting cuda graphs in descending order uses slightly less memory during initialization
using the following command on 1 A10G
without cuda graphs sorted
22140/23028 MiB
are used and with them sorted21938/23028 MiB
are used.This is a small percent of total memory (
<1%
) however it's 202 MiB saved. Additionally looking at the memory usage overtime, loading in descending order has smaller spike (never goes above its final value, where in ascending it peaks higher than 22222 MiB)Below are the two memory recording with https://github.com/drbh/nvline, left is ascending, and right is descending.