Idefics2: sync added image tokens with transformers #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
bugfix/idefics2-no-image-splitting
branch
9 times, most recently
from
99be263 to
9ce4552
Compare
5 tasks
Narsil
reviewed
Jun 24, 2024
router/src/validation.rs
Outdated
| .. | ||
| })) | ||
| ) { | ||
| tokens = tokens.repeat(5); |
There was a problem hiding this comment.
Careful about the removal of contiguous <fake> tokens in the preprocessor.
There was a problem hiding this comment.
Done. I'm now doing it in the same way as transformers. First add the duplicate tokens, then substitute them away.
I first wanted to make the image token processing aware of preceding chunks and only add a preceding fake token if there was not a preceding image (and then only intersperse the image splits with a single fake token). But that seemed like a bit of premature optimization of the image token processing.
danieldk
force-pushed
the
bugfix/idefics2-no-image-splitting
branch
3 times, most recently
from
1f1f4be to
8cafd28
Compare
Narsil
previously approved these changes
Jun 27, 2024
Before this change, the number of reserved image tokens was not the same as the number of images. Fixes #2029. While at it, also remove all the image token handling duplication in `prepare_input`.
danieldk
force-pushed
the
bugfix/idefics2-no-image-splitting
branch
from
8cafd28 to
80b448c
Compare
Narsil
approved these changes
Jun 27, 2024
4 tasks
glegendre01
pushed a commit
that referenced
this pull request
Jul 2, 2024
Before this change, the number of reserved image tokens was not the same as the number of images. Fixes #2029. While at it, also remove all the image token handling duplication in `prepare_input`.
yuanwu2017
pushed a commit
to yuanwu2017/tgi-gaudi
that referenced
this pull request
Sep 26, 2024
Before this change, the number of reserved image tokens was not the same as the number of images. Fixes huggingface#2029. While at it, also remove all the image token handling duplication in `prepare_input`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this change, the number of reserved image tokens was not the same as the number of images. Fixes #2029.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.