Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layers): fix SuRotaryEmbedding #2060

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix(layers): fix SuRotaryEmbedding #2060

merged 3 commits into from
Jun 12, 2024

Conversation

OlivierDehaene
Copy link
Member

Close #2055

@OlivierDehaene OlivierDehaene merged commit 90184df into main Jun 12, 2024
5 of 6 checks passed
@OlivierDehaene OlivierDehaene deleted the fix/phi_mini branch June 12, 2024 16:24
@Narsil Narsil mentioned this pull request Jun 24, 2024
5 tasks
@jphme
Copy link

jphme commented Jul 4, 2024

Did anyone test this change?
I can't use TGI with Phi-3 mini 128k for anything above 4k context - see #2185.

yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this pull request Sep 26, 2024
* fix(layers): fix SuRotaryEmbedding

* change arange

* remove logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor/inconsistent results from Phi-3-mini-128k
2 participants