fix(router): fix openapi and add jsonschema validation #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbh
previously approved these changes
Feb 19, 2024
drbh
previously approved these changes
Feb 19, 2024
OlivierDehaene
commented
Feb 20, 2024
Comment on lines
+342
to
+343
| for warper in self.warpers: | ||
| _scores = warper(input_ids, _scores) |
There was a problem hiding this comment.
@drbh it's very important that logits processor are done BEFORE warpers. Otherwise you can generate nonsense. For example if top_k is set and you warp before the grammar processor, may remove all valid tokens and you cannot generate anything. See #1539 (comment)
There was a problem hiding this comment.
thank you for pointing out! this is very helpful and makes a lot of sense. Thanks for resolving!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drbh, can you check the validation part?