feat: add mocked http request tests #1395
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two http request tests, and adds helper functions to test JSON requests and expected outputs.
Notes:
tower = "0.4.13"
so we can use thetower::util::ServiceExt
trait to allowoneshot
requests in the tests without starting an HTTP server.skip_generation
has been added toGenerateParameters
as a way to avoid making requests to the router.@Narsil and @OlivierDehaene please let me know what you think of this approach and if there is a better way to implement tests (the longer term goal is to improve TGI's API and these tests may be helpful when extending the API)