Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stripping of the prefix space (and any other mangling that tokenizers might do). #1065

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Sep 26, 2023

Superseed #1024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

OlivierDehaene
OlivierDehaene previously approved these changes Sep 27, 2023
@Narsil Narsil merged commit b32e9ce into main Sep 27, 2023
@Narsil Narsil deleted the fix_strip_prefix_space branch September 27, 2023 10:13
@bangoz
Copy link

bangoz commented Sep 27, 2023

Hi, I'm the author of #1024 (comment).
I found simply reusing decode_token is elegant, but it may return an empty output if the generated text ends with a token that only represent half of a utf-8 character. That's why in the original PR I created a new but similar function .
Thanks a lot for reviewing my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants