Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position ids logic instantiation of idefics vision part #1064

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix position ids logic instantiation of idefics vision part #1064

merged 3 commits into from
Sep 26, 2023

Conversation

VictorSanh
Copy link
Contributor

@VictorSanh VictorSanh requested a review from Narsil September 26, 2023 12:23
Narsil
Narsil previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's make sure integration tests pass.

@Narsil Narsil merged commit 1fff674 into main Sep 26, 2023
@Narsil Narsil deleted the vs/fix_pos_ids_idefics branch September 26, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narsil Narsil Narsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorSanh @Narsil